Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable EIP-6110 in pytest #3309

Merged
merged 22 commits into from
May 2, 2023
Merged

Enable EIP-6110 in pytest #3309

merged 22 commits into from
May 2, 2023

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Mar 28, 2023 •
edited
Loading

Enable EIP-6110 in pytest and add CI jobs

TODO:

  • check test generators

p.s. GitHub Actions errors can be ignored now. CircleCI still covers all.

@mkalinin
Copy link
Contributor

mkalinin commented Apr 6, 2023

The following things have been done so far:

  • Tests from test_process_deposit are ported to test_process_deposit_receipts
  • Deposit transition tests are implemented in test_deposit_transition
  • EIP6110 spec is rebased to Deneb
  • Couple of tests from test_polynomial_commitments are fixed by adding @always_bls annotation

We can try out test generators after fixing CI

@Dawidowak

This comment was marked as spam.

Sign in to view
@mkalinin
Copy link
Contributor

mkalinin commented Apr 6, 2023 •
edited
Loading

Test vectors for EIP-6110 produced by sanity and operations generators:

Updated test vectors to comply to the sanity format:

Third (hopefully the last 😄) version:

@hwwhww hwwhww marked this pull request as ready for review April 7, 2023 07:27
mkalinin
mkalinin approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready for the merge now. We can fix any issues if occur in a separate changes. Thanks a lot to @hwwhww for the outstanding help with these tests!

@hwwhww hwwhww merged commit 1946ed6 into dev May 2, 2023
@hwwhww hwwhww deleted the eip6110-tests branch May 5, 2023 08:11
@hwwhww hwwhww mentioned this pull request May 18, 2023
Merged
@lucassaldanha lucassaldanha mentioned this pull request Jan 18, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J1psy-HUSSLE J1psy-HUSSLE J1psy-HUSSLE left review comments

@kldeacy6 kldeacy6 kldeacy6 approved these changes

@mkalinin mkalinin mkalinin approved these changes

Assignees
No one assigned
Labels
EIP-6110
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hwwhww @mkalinin @Dawidowak @J1psy-HUSSLE @kldeacy6